workspace cache #632
workspace cache #632
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
|
|
||
| ```js | ||
| const cache = await workspace.cache("summary") |
There was a problem hiding this comment.
Incorrect use of 'await' outside of an async function.
generated by pr-docs-review-commit
await_usage
| const cache = await workspace.cache("summary") | ||
| // write entries | ||
| await cache.set("file.txt", "...") |
There was a problem hiding this comment.
Incorrect use of 'await' outside of an async function.
generated by pr-docs-review-commit
await_usage
| await cache.set("file.txt", "...") | ||
| // read entries | ||
| const content = await cache.get("file.txt") |
There was a problem hiding this comment.
Incorrect use of 'await' outside of an async function.
generated by pr-docs-review-commit
await_usage
| values: async () => | ||
| res.entries().then((es) => es.map((e) => e.val)), | ||
| } | ||
| }, |
There was a problem hiding this comment.
There is no error handling for the JSONLineCache.byName<any, any>(name) function call. If this function fails, it could lead to unexpected behavior. Consider adding error handling to improve the robustness of your code. 😊
generated by pr-review-commit
missing_error_handling
| @@ -105,6 +104,7 @@ export async function createPromptContext( | |||
| readJSON: (f) => runtimeHost.workspace.readJSON(f), | |||
| readXML: (f) => runtimeHost.workspace.readXML(f), | |||
| writeText: (f, c) => runtimeHost.workspace.writeText(f, c), | |||
| cache: (n) => runtimeHost.workspace.cache(n), | |||
There was a problem hiding this comment.
The runtimeHost.workspace.cache(n) function call lacks error handling. If this function fails, it could lead to unexpected behavior. It's a good practice to handle potential errors to make your code more reliable. 😊
generated by pr-review-commit
missing_error_handling
| */ | ||
| cache<K = any, V = any>( | ||
| cacheName: string | ||
| ): Promise<WorkspaceFileCache<K, V>> |
There was a problem hiding this comment.
The cache<K = any, V = any>(cacheName: string) function does not validate the types of its parameters. This could lead to unexpected behavior if the function is called with incorrect types. Consider adding type validation to improve the robustness of your code. 😊
generated by pr-review-commit
missing_type_validation
Simple KV store to implement cheap memories in scripts